VecView: fix memory leak of drop #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
vecview-drop
branch
from
50c047b
to
d7ed3be
Compare
Drop must also be implemented on `VecView` for the cases wher the `VecView` is owned even if it is `!Sized`. This can happen when it is boxed.
This represent more clearly the role of the trait now that it's not used to work around drop specialization.
sosthene-nitrokey
force-pushed
the
vecview-drop
branch
from
d7ed3be
to
fc133a9
Compare
reitermarkus
approved these changes
May 24, 2024
Merged
via the queue into
rust-embedded:main
with commit May 24, 2024
1f25e65
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the initial implementation, I implemented
DropforVecbut I implemented it as ano-opforVecView, thinking that it should only be dropped throughVec.This is incorrect,
VecViewcan be responsible for dropping its content when its owned, for example in aBox.This PR adds a test that fails with the current implementation, showing the memory leak, and fixes it by implementing
Dropproperly forVecView